Add fix for Qwen3Coder tool parser quote handling #3727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atobiszei
force-pushed
the
atobisze_qwen3coder_escape_quotes
branch
2 times, most recently
from
bb763c2 to
572d366
Compare
* Improve tests to verify if produced output is proper JSON
atobiszei
force-pushed
the
atobisze_qwen3coder_escape_quotes
branch
from
572d366 to
e288b6d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes quote handling in the Qwen3Coder tool parser by introducing proper escaping of double quotes within string parameters. The fix ensures that JSON arguments containing quotes are properly escaped, preventing JSON parsing errors.
Key Changes
- Added
escapeQuotes()function to escape double quotes in string values - Updated
setCorrectValueType()to use the new escaping function for STRING parameters - Enhanced test coverage to validate that generated JSON is parsable, including edge cases with Python triple-quoted strings and nested quotes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/llm/io_processing/qwen3coder/qwen3coder_tool_parser.cpp | Implements quote escaping logic to fix JSON generation for string parameters |
| src/test/llm/output_parsers/qwen3coder_output_parser_test.cpp | Adds test cases with complex string content and JSON validation checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkalinowski
reviewed
Nov 4, 2025
| } else { | ||
| parameterValue = escapeString(setCorrectValueType(parameterValue, this->currentParameterName, paramIt->second)); | ||
| // we don't want to escape entry/exit " for string parameters | ||
| parameterValue = escapeNewline(setCorrectValueType(parameterValue, this->currentParameterName, paramIt->second)); |
Collaborator
There was a problem hiding this comment.
why newline only for booleans and quotes only for strings?
dkalinowski
approved these changes
Nov 4, 2025
mzegla
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:CVS-175213